Ticket #1603 (closed enhancement: fixed)

Opened 6 months ago

Last modified 4 months ago

More width and showing the SymbolTable on editing objects in the Algebra view

Reported by: johannes Owned by: george
Priority: medium Milestone: GeoGebra 4.2
Component: AlgebraView Keywords: algebra view, width
Cc: Estimate (h): 0
Progress (%): 100

Description

On double clicking an GeoElement in the Algebra view a text box replaces the element where you can edit this element.
This text box should be as broad as possible (till the border of the Algebra view) and the button for the SymbolTable should be visible there.

Change History

comment:1 Changed 6 months ago by johannes

  • Owner set to Michael
  • Component changed from General to AlgebraView

comment:2 Changed 6 months ago by markus

  • Owner changed from Michael to george
  • Status changed from new to assigned

Idea (from Lucas): maybe we could use an editable tooltip?

comment:3 Changed 6 months ago by george

fixed in r13728

The symbol table popup takes too much space when the AV width is small, so it only appears when the width is above 100px.

Not sure is editable tooltips are possible, but will investigate in the future :)

comment:4 Changed 6 months ago by george

  • Status changed from assigned to closed
  • Progress (%) changed from 0 to 100
  • Resolution set to fixed

comment:5 Changed 6 months ago by johannes

  • Keywords SymbolTable, removed
  • Progress (%) changed from 100 to 80
  • Status changed from closed to reopened
  • Resolution fixed deleted

I have tested that and got the following:
# the alpha for the symbol table is always visible (which is fine)
# the resizing of the TextBox is only working, if i have edited the value of the TextBox immediately (see example below)

Example:
I doubleclick on a GeoElement in the Algebra view --> the TextBox appears with correct width --> i resize the AlgebraView --> the width of the TextBox does NOT change --> i edit the value in the TextBox --> i resize the AlgebraView --> the width of the TextBox changes to the correct width --> i resize the AlgebraView again --> the width of the TextBox does NOT change

Tested on Mac OS X 10.6.8 and GeoGebra 4.1.25.0

comment:6 Changed 6 months ago by george

Looking at this problem (cell editor width not updating on split pane resize) revealed another problem: The AV cell editor did not cancel editing on lost focus. I have fixed this by adding a focus listener to the cell editor text field and adding a property change listener to DockSplitPane. The property change listener transfers focus to the DockSplitPane after a split pane resize event, thus removing focus from its components and sending a focus lost event to an open AV cell editor.

With these changes, cell editing in the AV is now canceled when the AV panel is resized. (Trying to get the editor text field to resize as the split pane changed would require more hassle for little benefit.)


comment:7 Changed 4 months ago by george

  • Status changed from reopened to closed
  • Progress (%) changed from 80 to 100
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.