Ticket #1786 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

web: hit testing problem (tools)

Reported by: michael Owned by: gabor
Priority: critical Milestone: GeoGebraWeb Alpha 3
Component: GeoGebraWeb Keywords:
Cc: zbynek, gabor Estimate (h): 0
Progress (%): 100

Description

The parallel line tool doesn't work properly when the mouse is inside a circle (even a large one) inside a polygon or eg near a segment.
http://www.geogebra.org/web/milestones/ggbWebTools.html

The preview line should follow the mouse exactly unless the mouse goes near a POINT

(NB click on a line to activate the preview)

Change History

comment:1 Changed 4 months ago by michael

It's more obvious with the Polygon (16) Tool - you can't place a point inside a circle

comment:2 Changed 4 months ago by michael

  • Priority changed from major to critical
  • Milestone changed from GeoGebraWebGui to GeoGebraWeb Alpha 3

It's just just for Tools, it's for all conic hit testing. The problem is that this isn't implemented in geogebra.web.awt.BasicStroke so we can't tell if points are on the edge or inside

	public geogebra.common.awt.Shape createStrokedShape(
            geogebra.common.awt.Shape shape) {
	    AbstractApplication.debug("implementation needed"); // TODO Auto-generated
	    return shape;
    }
	

comment:3 Changed 4 months ago by michael

  • Priority changed from critical to very high

Fixed for conics:
http://www.geogebra.org/trac/changeset/15453

Still needs fixing for Loci, DrawConicPart, PolyLine & Parametric curves

Last edited 4 months ago by michael (previous) (diff)

comment:4 Changed 4 months ago by michael

  • Priority changed from very high to critical

comment:5 Changed 4 months ago by michael

  • Cc gabor added
  • Progress (%) changed from 0 to 90

This should fix it properly:
http://www.geogebra.org/trac/changeset/15456

(not fully tested yet)

comment:6 Changed 4 months ago by michael

  • Status changed from new to closed
  • Progress (%) changed from 90 to 100
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.